Skip to content

Timestamps are lost #164

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
posva opened this issue Feb 13, 2018 · 1 comment
Closed

Timestamps are lost #164

posva opened this issue Feb 13, 2018 · 1 comment
Labels
bug firestore new Cloud Store

Comments

@posva
Copy link
Member

posva commented Feb 13, 2018

Right now non-plain objects like timestamps are not being converted correctly, therefore, they're lost, transformed into empty objects instead. This is actually visible in the example
@posva posva added bug firestore new Cloud Store labels Feb 13, 2018
posva pushed a commit that referenced this issue Feb 14, 2018
@epall @posva
fix: properly copy Dates
1bd4450 
Fix #164
Firestore has native support for timestamps, which show up in JS as `Date` objects. We need a special case in `extractRefs` because recursing into a `Date` and copying its fields doesn't produce a proper copy. Instead we should pass it through the same way we do with more fundamental types, like strings or numbers.
@posva
Copy link
Member Author

posva commented Feb 14, 2018

Fixed in #165

@posva posva closed this as completed Feb 14, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug firestore new Cloud Store
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@posva