Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Doc #13

Closed
ktquez opened this issue Oct 20, 2016 · 3 comments
Closed

Fix Doc #13

ktquez opened this issue Oct 20, 2016 · 3 comments
Assignees
Milestone

Comments

@ktquez
Copy link

ktquez commented Oct 20, 2016

Hello Mark, blz
Thanks for excellent job in package!

I tried to register the components separately and how was documentation.
Vue.use(VueMaterial.MdCore); //Required to boot vue material
Then the components that need, e.g.
Vue.use(VueMaterial.MdToolbar);

But I looked at your code and the property only worked, at least in my project, with property starting with a lowercase letter, for example.
Vue.use(VueMaterial.mdCore);
Vue.use(VueMaterial.mdToolbar);

It may be a problem with the name resolution in my project, but it will be what happens to anyone else?
If so, just change the doc, thanks

Or, if you are normal for most, please disregard

@ktquez
Copy link
Author

ktquez commented Oct 20, 2016

Ahhh, in my project I'm using SSR, can possibly be so.
I'm waiting

@marcosmoura
Copy link
Member

@ktquez Yeah. You're right. This is really a small problem in my package. I'll change this ASAP.
I never tried those components with ssr, but I think that they will work. Can you give me a feedback about it if you try this before me?

@ktquez
Copy link
Author

ktquez commented Oct 20, 2016

@marcosmoura
Using with SSR had some problems but mainly by manipulating the DOM, but fix it using
the jsdom-global, e.g.

require('jsdom-global')(htmlMarkup, { url: 'http://host:port' })

This fixes me.

@marcosmoura marcosmoura added this to the v0.1.3 milestone Oct 21, 2016
@marcosmoura marcosmoura self-assigned this Oct 21, 2016
@marcosmoura marcosmoura modified the milestone: v0.1.3 Oct 21, 2016
@marcosmoura marcosmoura modified the milestones: v0.1.3, v0.2.0 Oct 21, 2016
marcosmoura added a commit that referenced this issue Nov 14, 2017
* comp(MdDialog): add initial files for dialogs

* test(MdDialog): fix broken tests

* comp(MdDatepicker): crate initial files for date picker

* comp(MdDialog): crate initial styles for dialog

* fix(MdDialog): fix overlay not being rendered on the correct place

* test(MdDialog): add initial tests

* fix(MdDialog): fix wrong imports

* fix(MdDialog): move file to its right place

* fix(MdFile): fix conflicts
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants