Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[MdRipple] does not work on buttons in Firefox #1461

Closed
anckaertr opened this issue Jan 31, 2018 · 2 comments · Fixed by #1468
Closed

[MdRipple] does not work on buttons in Firefox #1461

anckaertr opened this issue Jan 31, 2018 · 2 comments · Fixed by #1468
Labels
bug

Comments

@anckaertr
Copy link

Steps to reproduce

simply add a button on a page.

Which browser?

Firefox 57.x, Firefox 58.x

What is expected?

the ripple effect

What is actually happening?

Nothing
@Samuell1 Samuell1 added the bug label Jan 31, 2018
@Samuell1 Samuell1 changed the title Ripple does not work on buttons in Firefox [MdRipple] does not work on buttons in Firefox Jan 31, 2018
@Samuell1
Copy link
Member

Doesnt work only if md-button element is button because elements inside button doesnt have events.

@VdustR VdustR mentioned this issue Feb 2, 2018
Merged
@Soletiq
Copy link

Soletiq commented Feb 12, 2018

+1 please fix

marcosmoura pushed a commit that referenced this issue Feb 20, 2018
@VdustR @marcosmoura
fix(MdButton): Ripple for firefox (#1468)
156506b 
* fix(MdButton): Ripple for firefox

fix #1461

* refactor(MdButton): new computed `rippleWorks`

* refactor(MdButton): active ripple by props instead of method call

* refactor(MdButton): remove unnecessary events
@VdustR VdustR mentioned this issue Apr 2, 2018
Closed
@VdustR VdustR mentioned this issue Apr 16, 2018
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(MdButton): Ripple for firefox
3 participants
@Samuell1 @Soletiq @anckaertr