Skip to content

Low framerate #29

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
plievone opened this issue Oct 25, 2016 · 6 comments
Closed

Low framerate #29

plievone opened this issue Oct 25, 2016 · 6 comments
Assignees
Milestone

Comments

@plievone
Copy link

plievone commented Oct 25, 2016

Hi, vue-material seems very promising! Could you look into why framerate is quite low on mobile Chrome (Android 5)? For example if you compare opening

in mobile browser and toggling sidebar/drawer, and then compare it to some other vue.js material implementations such as

Most run with much higher framerate. It is not only the sidebar, but other animations too, the problem is just most visible with the sidebar action. Perhaps there is a simple change that would fix it across the framework?

@marcosmoura
Copy link
Member

Oh. I see. Sorry about that. I need to investigate this better but I think that the problem is happening when the toggle class apply a different box-shadow with other properties. I have noticed this behavior with tabs too. I will prioritize and fix this in the very next release.

Thank you for reporting this!

@marcosmoura marcosmoura self-assigned this Oct 25, 2016
@marcosmoura marcosmoura added this to the v0.2.1 milestone Oct 25, 2016
@plievone
Copy link
Author

That's good to hear! Also ripple effects could be one source of performance problems. So could the documentation site have a global option (query parameter, local storage toggle, something else) to disable ripple effects easily for trying out in mobile. In any case, perhaps you could expose this line https://github.com/marcosmoura/vue-material/blob/b5bdea0/src/core/index.js#L23 via some option parameter so that one can opt out of ripples. As a quick change one can also disable ripple on that hamburger menu button in docs, as currently that may invalidate layout unnecessarily behind the opening menu (haven't looked much yet). I'm looking forward to follow and experiment with vue-material, quality work.

@marcosmoura marcosmoura modified the milestones: v0.2.1, v0.3.0 Nov 11, 2016
@marcosmoura
Copy link
Member

The problem was found and was related with box shadow transition. Unfortunately this will be delayed to v0.4.0 because needs more tests and the boost that this fix will provide will be applied to other components.

@marcosmoura marcosmoura modified the milestones: v0.4.0, v0.3.0 Nov 14, 2016
@marcosmoura
Copy link
Member

Well. Thiss is quite fixed. For the sidenav it's done. For the other components, since they need some other improvements, I will delay this a little bit. Notice that this lib is in constant development, so a lot of things will be improved/changed until the first stable version.
Thanks!

@mubaidr
Copy link

mubaidr commented Mar 16, 2017

I am experience similar issue with latest build (0.7.1).
i7 3.4Ghz with 8Gb Ram
Windows 10 64bit

With header, toolbar and 11 cards in a page frame-rate drops in Chrome, Opera. But Edge/IE has horrible performance.

May i know how you will approach the fix for this issue?
@marcosmoura Can we use border images in-place of box-shadow to fix performance related issues? (Considering that we have 24 levels of shadow, this might be difficult.)

marcosmoura added a commit that referenced this issue Nov 14, 2017
* comp(MdTable): create base files for dynamic table

* test(MdTable): remove test

* comp(MdTable): rename base files

* feat(MdTable): create base styles and sort functionality

* feat(MdTable): create base styles for selection

* feat(MdTable): add auto sort

* feat(MdTable): create fixed headers

* feat(MdTable): improve examples

* feat(MdTable): improve examples

* perf: add bundle analyzer and cut almost 20% of garbage

* perf: add bundle analyzer only on minified build

* chore: remove garbage

* refactor(MdField): improve transition when focused

* revert(MdSelect): readd disabled parameter to fake input

* feat(MdTable): better look for fixed header

* feat(MdTable): add the great and new empty state for tables

* feat(MdTable): fine tune empty state for tables

* docs(Core): make home icons appear

* docs(Core): finish new home layout
@janschloss
Copy link

Same here, especially for the select component.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

4 participants