Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(MdMenu): fix close-on-select props #1280

Merged
merged 1 commit into from
Dec 19, 2017
Merged

fix(MdMenu): fix close-on-select props #1280

merged 1 commit into from
Dec 19, 2017

Conversation

VdustR
Copy link
Member

@VdustR VdustR commented Dec 8, 2017

check whether clicked target is contained in menu content element within bodyClickObserver

I found that this.$el is always <!-- --> here. Add a statement isMenuContentEl to prevent menu closing from bodyClickObserver.

MdMenu, MdSelect, MdAutocomplete tested.

Note that md-close-on-select only fire close event fired while there are one or more interaction events bound on md-menu-item

fix #1279

check whether clicked target is contained in menu content element within `bodyClickObserver`

fix #1279
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu :md-close-on-select="false" not working
2 participants