feat(MdRipple): multiple waves #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Samuell1
commented
Jan 21, 2018
Samuell1
commented
VdustR
reviewed
Jan 22, 2018
src/components/MdRipple/MdRipple.vue
Outdated
| }, delay) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I think this method could put it into /src/core/utils and name it MdDebounce.
It could be shorter with es6:
const debounce = (fn, delay) => {
let timeoutID = null
return (...args) => {
clearTimeout(timeoutID)
timeoutID = setTimeout(() => fn(...args), delay)
}
}
marcosmoura
approved these changes
Jan 23, 2018
marcosmoura
pushed a commit
that referenced
this pull request
Jan 29, 2018
* origin/dev: (72 commits) docs: add ie polyfills (#1342) fix(MdTooltip): `mdActive` never updated to true using `.sync` modifier chore: new component script (#1455) fix(MdTabs): fix indicator (#1448) fix(MdSelect): Reactive options (#1447) fix(MdTooltip): overlaying in dialog (#1446) fix(MdTabs): correct indicator position while alignment changed (#1442) fix(MdProgressSpinner): undefined navigator on SSR (#1441) docs(MdTabs): add missing md-icon prop (#1439) fix(MdRipple): clear ripples if called programatically (#1431) feat(MdListItemExpand): reactive expansion (#1435) feat(MdDatepicker): emit date without confirming (#1426) feat(MdDatepicker): add dateformat (#1436) feat(MdRipple): multiple waves (#1419) feat(MdDatepicker): custom first day of a week (#1409) feat(MdDatepicker): remove fixed label position (#1417) docs(MdDialog): add note about scrollable content (#1416) Update sponsorship links (#1427) fix(MdAutocomplete): prevent show options twice (#1410) fix(MdField): Consider number `0` as hasValue (#1407) ...
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.