Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(MdTabs): remove ResizeObserver #1552

Merged
merged 1 commit into from
Feb 28, 2018
Merged

fix(MdTabs): remove ResizeObserver #1552

merged 1 commit into from
Feb 28, 2018

Conversation

Samuell1
Copy link
Member

Fix #1513

Maybe it can resolve #1500 ?

@Samuell1 Samuell1 requested a review from marcosmoura February 25, 2018 17:58
@mrwhy-orig
Copy link
Contributor

I can confirm that this fix + the fix #1506 is solving a part of #1500. But there is one case left. If there is a child md-tabs with only 1 md-tab it is not calculating the height.
I tried to demonstrate it with a pen, you have to use the "debug" view because the whole fix isn't working in editor view.
https://codepen.io/MrWhy/pen/QQZZme?editors=1111

@marcosmoura
Copy link
Member

@Samuell1 @mrwhy-orig We can merge this one and work on another fix for this case. Will be better.

@marcosmoura marcosmoura merged commit ef0cd2f into dev Feb 28, 2018
@marcosmoura marcosmoura deleted the fix/MdTabs/call-resize-functions branch February 28, 2018 18:12
@mrwhy-orig
Copy link
Contributor

@marcosmoura should I open another issue on this?

@Samuell1 Samuell1 mentioned this pull request Apr 16, 2018
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@marcosmoura marcosmoura Awaiting requested review from marcosmoura

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MdTabs] content height is not set with async data [MdTabs] content length calculations
3 participants
@Samuell1 @mrwhy-orig @marcosmoura