docs(SpeedDial): better position direction demo #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosmoura
added a commit
that referenced
this pull request
Jun 9, 2018
* origin/dev: fix(MdAutocomplete): fix option selecting (#1765) docs(SpeedDial): better position direction demo (#1772) fix(MdSnackbar): add "persistent" argument to createPromise() fix(MdTabs): setupObservers on mounted immediately (#1770) fix(MdMenuContent): destroy keydown listener on Esc (#1766) fix(MdTable): revert asc direction (#1776) fix(MdTable): sort on created (#1775) fix(MdTable): provide value mutation (#1789) fix(MdFile): disabled icon (#1787) feat(MdCardExpandContent): reactive content (#1799) feat(MdRadio): object support (#1771) fix(MdFile): infinite focus loop fix(MdSelect): selected event before mounted docs(Checkbox): Missed Object type added to doc description docs(GettingStarted): Change CDN urls from v1.0.0-beta-7 to latest
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the demo to a better way in my opinion.
I don't think
z-indexis the best solution because there might be some other components withz-indexhigher than2, than you should put higherz-indexfor that. You'll never know how high the components the Vue Material user put in the content. In this case, you'll always need to add a higherz-indexfor that. So, setz-indexis a solution only for the demo case.The demo render as unexpected is just because the speed dials are append before the buttons. If they are after the buttons it would looks fine.
Additionally, I replace the native buttons with Vue Material buttons.
related to #1764