Fix the repeated generated css theme classes if there is multiple the… #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mes defined #simongcc
marcosmoura
added a commit
that referenced
this pull request
May 11, 2019
* origin: (55 commits) fix(MdSvgLoader): svg loader for invalid / missing mimetype (#1942) docs(Icon): fix minor typo (#1973) fix(MdRouterLink): new router-link registration name (#1978) chore: apply discord vanity URL (#1927) docs(ROADMAP.md): replace dead slack invite link with discord invite link (#1924) docs(Table): fix grammar issues (#1902) feat: router link components improvements (#1651) fix(MdTable): recalculate fixed header width on data changes (#1877) fix(MdDialogContent): missing theme class (#1876) docs(Elevation and Layout): Typos fixed and improved documentation. (#1878) fix(MdTable): nextTick selection data (#1874) docs(BottomBar): fix typo (#1875) docs(MdButton): escape a tag (#1872) docs(Input): typos and correction chore: upgrade dependencies fix(MdField): remove firefox required box-shadow feat: disable complexity rules for some methods fix(MdProgressSpinner): fix CSP error (#1850) fix: MdBadge do not accept color #1854 issue (#1856) fix: fix the repeated generated css theme classes if there is multiple themes defined (#1784) ...
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mes defined #simongcc
Refer to issue #1670
Fix the duplication in generating multiple css classes when there is multiple themes by adding a $md-theme-name variable to track the current reading theme during running the css generation loop while generating all css for all components.
It fix the following mixins
md-theme-component()
md-theme-component-relative()