Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: update Vue Storefront core packages to 2.7.5 #291

Conversation

fpdrozd
Copy link
Contributor

@fpdrozd fpdrozd commented Mar 22, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Tested by performing a checkout pass.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@rafalcymerys
Copy link
Collaborator

@fpdrozd I think there's something wrong with the Test & Lint / Test api-client and composables (pull_request) step. It fails when building the api-client. Could you take a look?

@fpdrozd fpdrozd force-pushed the chore/update-storefront-2.7.5 branch from f8799d1 to 86784a8 Compare March 22, 2023 10:32
@fpdrozd
Copy link
Contributor Author

fpdrozd commented Mar 22, 2023

@rafalcymerys This is probably related to the axios upgrade in storefront (vuestorefront/vue-storefront#6848). I've added explicit response typing for the getPaymentConfirmationData and getPaymentMethods api calls. Should work now.

Btw, what is that intents spree api endpoint? (/api/v2/storefront/intents/payment_confirmation_data). Couldn't find it in the docs. Is it some custom Stripe integration?

@rafalcymerys
Copy link
Collaborator

It's core Spree, but it could be missing from the docs. Let's take a look at it and make sure it's in swagger.

@rafalcymerys rafalcymerys merged commit 38cbf48 into vuestorefront-community:main Mar 22, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants