Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: update Storefront UI to 0.12.3 #292

Conversation

fpdrozd
Copy link
Contributor

@fpdrozd fpdrozd commented Mar 23, 2023

This PR updates the Storefront UI to 0.12.3 according to the migration guide.

Description

The major refactoring relates to how SfImage component is defined. Now it requires width and height properties to determine the aspect ratio of an image. Then the size can be changed via css to fit the responsive layout.
More details: here.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@rafalcymerys rafalcymerys merged commit bd772e3 into vuestorefront-community:main Mar 23, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants