fix: sourcemap not found and loading crash in nuxt #313
+119
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linspw
commented
Aug 28, 2023
| @@ -158,12 +176,16 @@ export function stylesPlugin (options: Options): Plugin { | |||
| ) | |||
| ) { | |||
| if (options.styles === 'none') { | |||
linspw
commented
Aug 29, 2023
| @@ -15,101 +15,122 @@ function isSubdir (root: string, test: string) { | |||
| return relative && !relative.startsWith('..') && !path.isAbsolute(relative) | |||
| } | |||
|
|
|||
| // FOR SOME REASON: /�plugin-vuetify:/home/jesse/Documents/personal/nuxt/vuetify/lib/styles/main.sass?direct 16:53:03 | |||
| const PLUGIN_VIRTUAL_PREFIX = "virtual:" | |||
There was a problem hiding this comment.
|
👍 Hope this helps |
|
Hi @KaelWD . If it's not a problem, could you see if this PR makes sense please? |
|
@KaelWD Can you please review it? |
|
any news? |
|
will this merged? |
|
Hello guys, Any expected timeline on when this will be fixed? It's the only thing that stops Nuxt users from being able to customize SASS variables. |
|
Hello, is there any news on this? hope it gets merged soon |
|
This wasn't merged because it basically rewrites the entire plugin for no reason, if it's still relevant please only include changes necessary to fix the issue. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everything is fine?
This Pull request has 3 objectives:
BUGS:
The relative path of the target was making the nuxt load break, for some reason the path was generating a url that didn't match the file.
The other sourcemap bug was caused by the \0 prefix, where the virtual is what nuxt is prepared to read (I imagine this change won't break vite builds).
#311
#290
Thanks in advance for your attention, feel free to adjust.