Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Bug Report][3.3.23] No button element for VChip close button #18547

Closed
deraw opened this issue Oct 25, 2023 · 0 comments · Fixed by qburst/vuetify#2 or #18571
Closed

[Bug Report][3.3.23] No button element for VChip close button #18547

deraw opened this issue Oct 25, 2023 · 0 comments · Fixed by qburst/vuetify#2 or #18571
Assignees
@johnleider
Labels
C: VChip T: bug Functionality that does not work as intended/expected
Milestone
v3.4.x

Comments

@deraw
Copy link

deraw commented Oct 25, 2023

Environment

Vuetify Version: 3.3.23
Vue Version: 3.3.7
Browsers: Chrome 118.0.0.0
OS: Windows 10

Steps to reproduce

Inspect the close element of the chip

Expected Behavior

The element should be a <button> so it's accessible by keyboard and properly exposed to screen readers

Actual Behavior

It's a <div>

Reproduction Link

https://play.vuetifyjs.com/#...

Other comments

This is a regression from v2
This was referenced Nov 1, 2023
Merged
Merged
@johnleider johnleider self-assigned this Dec 11, 2023
@johnleider johnleider added T: bug Functionality that does not work as intended/expected C: VChip and removed S: triage labels Dec 11, 2023
@johnleider johnleider added this to the v3.4.x milestone Dec 11, 2023
johnleider pushed a commit that referenced this issue Dec 11, 2023
@amal-qb
fix(VChip): use button element for closable button (#18571)
50e48d5 
closes #18547
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@johnleider johnleider

Labels
C: VChip T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v3.4.x
2 participants
@johnleider @deraw