Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Bug Report][3.6.10] Time picker : Warning events when minutes is set to 0 #20085

Closed
edimitchel opened this issue Jul 1, 2024 · 0 comments · Fixed by #20126 or Enterprise-CMCS/cmcs-eregulations#1413 · May be fixed by Equoa1/Thiio-Laravel-Vue#1 or jonathanestefani/crud_vuetify#5
Closed

[Bug Report][3.6.10] Time picker : Warning events when minutes is set to 0 #20085

edimitchel opened this issue Jul 1, 2024 · 0 comments · Fixed by #20126 or Enterprise-CMCS/cmcs-eregulations#1413 · May be fixed by Equoa1/Thiio-Laravel-Vue#1 or jonathanestefani/crud_vuetify#5
Labels
C: VTimePicker VTimePicker T: bug Functionality that does not work as intended/expected
Milestone
v3.6.x

Comments

@edimitchel
Copy link

Environment

Vuetify Version: 3.6.10
Vue Version: 3.4.30
Browsers: Firefox 127.0
OS: Mac OS 10.15

Steps to reproduce

Select hours, and minutes to something else than 0, then select 0.

Expected Behavior

No console warnings

Actual Behavior

Console logging 3 warning messages about bad payload emitted

Reproduction Link

https://play.vuetifyjs.com/#...

Other comments

This looks like 0 is treated as falsy value instead of actually a valid information
@edimitchel edimitchel changed the title [Bug Report][3.6.10] TIme picker : Warning events when minutes is set to 0 [Bug Report][3.6.10] Time picker : Warning events when minutes is set to 0 Jul 1, 2024
@SonTT19 SonTT19 mentioned this issue Jul 9, 2024
Merged
@KaelWD KaelWD added T: bug Functionality that does not work as intended/expected C: VTimePicker VTimePicker labels Jul 9, 2024
@KaelWD KaelWD added this to the v3.6.x milestone Jul 9, 2024
@github-actions github-actions bot removed the S: triage label Jul 9, 2024
KaelWD pushed a commit that referenced this issue Jul 9, 2024
@SonTT19
fix(VTimePicker): fix types for emit events (#20126)
5385260 
fixes #20085
@Equoa1 Equoa1 mentioned this issue Aug 7, 2024
Open
@Asthriona Asthriona mentioned this issue Aug 7, 2024
Closed
@brittag brittag mentioned this issue Sep 3, 2024
Merged
@jonathanestefani jonathanestefani mentioned this issue Sep 24, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
C: VTimePicker VTimePicker T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v3.6.x
2 participants
@edimitchel @KaelWD