Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(VMenu): check if element still exists before closing parent #20249

Merged
merged 2 commits into from
Jul 31, 2024
Merged

fix(VMenu): check if element still exists before closing parent #20249

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77eaacc
fix(v-menu): closeParents on destroyed overlays
Arinono Jul 30, 2024
7ff579f
apply feedback
Arinono Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vuetify/src/components/VMenu/VMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export const VMenu = genericComponent<OverlaySlots>()({
setTimeout(() => {
if (!openChildren.value &&
!props.persistent &&
(e == null || (e && !isClickInsideElement(e, overlay.value!.contentEl!)))
(e == null || (e && overlay.value && overlay.value.contentEl && !isClickInsideElement(e, overlay.value.contentEl)))
Arinono marked this conversation as resolved.
Show resolved Hide resolved
) {
isActive.value = false
parent?.closeParents()
Expand Down