Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(VField, VInput): emit click:* events using keyboard #20878

Merged
merged 4 commits into from
Jan 21, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
keep focus on the icon
  • Loading branch information
J-Sek committed Jan 20, 2025
commit fe766c22f03991c0765426cbcc589dac8282c935
14 changes: 10 additions & 4 deletions packages/vuetify/src/components/VInput/InputIcon.tsx
Original file line number Diff line number Diff line change
@@ -4,9 +4,6 @@ import { VIcon } from '@/components/VIcon'
// Composables
import { useLocale } from '@/composables/locale'

// Utilities
import { triggerAsClick } from '@/util'

// Types
import type { IconValue } from '@/composables/icons'

@@ -35,6 +32,15 @@ export function useInputIcon<T extends {}, K extends names = Listeners<T>> (prop
clear: 'clear',
}[name]
const listener = props[`onClick:${name}`]

function onKeydown (e: KeyboardEvent) {
if (e.key !== 'Enter' && e.key !== ' ') return

e.preventDefault()
e.stopPropagation()
;(listener as Function)?.(new MouseEvent('click'))
}

const label = listener && localeKey
? t(`$vuetify.input.${localeKey}`, props.label ?? '')
: undefined
@@ -44,7 +50,7 @@ export function useInputIcon<T extends {}, K extends names = Listeners<T>> (prop
icon={ props[`${name}Icon`] }
aria-label={ label }
onClick={ listener }
onKeydown={ triggerAsClick }
onKeydown={ onKeydown }
/>
)
}
8 changes: 0 additions & 8 deletions packages/vuetify/src/util/events.ts
Original file line number Diff line number Diff line change
@@ -15,11 +15,3 @@ export function getPrefixedEventHandlers<T extends `:${string}`> (
return acc
}, {} as Record<`${string}${T}`, EventHandler>)
}

export function triggerAsClick (e: KeyboardEvent) {
if (e.key !== 'Enter' && e.key !== ' ') return

e.preventDefault()
e.stopPropagation()
;(e.currentTarget as HTMLElement).click()
}