Add documentation for GraphicsPipelineAbstract #1083
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.md
if knowledge of this change could be valuable to usersThis PR better documents GraphicsPipelineAbstract by mentioning that your draw calls will now need the buffer to be wrapped in a vec.
I'm not convinced this is the best solution though, the ideal solution would be for GraphicsPipeline and GraphicsPipelineAbstract to function in the same way here. That is, both should allow a CpuAccessibleBuffer to be passed directly in the draw call.
I have no idea how to implement that though, the generics is doing my head in.
The code that handles it for GraphicsPipeline is here:
vulkano/vulkano/src/pipeline/graphics_pipeline/mod.rs
Line 504 in 7a11120
We need to find a way to implement this for GraphicsPipelineAbstract.
If such a thing is impossible then I will merge this PR instead.
The commit to add the linked code is 4c0a093
The commit to add
VertexSource<Vec<Arc<BufferAccess + Send + Sync>>>
is 64459fc#diff-1f6ce30b101af55aab9d8ea160fee761As mentioned in the issue, it looks like this will be resolved by later rust features, so I'll merge this as is and keep the issue open. #1082