Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add documentation for GraphicsPipelineAbstract #1083

Merged
merged 1 commit into from
Oct 26, 2018

Conversation

rukai
Copy link
Member

@rukai rukai commented Oct 21, 2018

  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes - in this repository
  • Updated documentation to reflect any user-facing changes - PR to the guide that fixes existing documentation invalidated by this PR.

This PR better documents GraphicsPipelineAbstract by mentioning that your draw calls will now need the buffer to be wrapped in a vec.

I'm not convinced this is the best solution though, the ideal solution would be for GraphicsPipeline and GraphicsPipelineAbstract to function in the same way here. That is, both should allow a CpuAccessibleBuffer to be passed directly in the draw call.

I have no idea how to implement that though, the generics is doing my head in.
The code that handles it for GraphicsPipeline is here:

unsafe impl<Mv, L, Rp, S> VertexSource<S> for GraphicsPipeline<Mv, L, Rp>

We need to find a way to implement this for GraphicsPipelineAbstract.
If such a thing is impossible then I will merge this PR instead.

The commit to add the linked code is 4c0a093
The commit to add VertexSource<Vec<Arc<BufferAccess + Send + Sync>>> is 64459fc#diff-1f6ce30b101af55aab9d8ea160fee761

As mentioned in the issue, it looks like this will be resolved by later rust features, so I'll merge this as is and keep the issue open. #1082

@rukai rukai merged commit 869c486 into vulkano-rs:master Oct 26, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant