Added overlapping_push_constant_ranges to PipelineLayout
#1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps us track overlapping ranges, and what stages belong into them. This will be used in the `push_constants` command to help fixing some issues regarding: - VUID-vkCmdPushConstants-offset-01795 - VUID-vkCmdPushConstants-offset-01796 And also solidify the implementation.
|
It looks good, thank you. I think the name of the function is a bit of a misnomer though. I would expect the ranges that it returns to not overlap. So maybe |
After this edit, `push_constants` will go through all `overlapping_push_constant_ranges` from `PipelineLayout` and pushes the overlapping subset of the data with the correct stages flags to satisfy VUID-vkCmdPushConstants-offset-01795 and VUID-vkCmdPushConstants-offset-01796. This commit also fixes buffer overflow bug when using offset that is not zero.
Amjad50
force-pushed
the
push_constants_fixes
branch
from
dc3c332 to
b6bfb68
Compare
|
Looks good and it runs without errors. Thank you! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1819
Added
overlapping_push_constant_rangesinPipelineLayout, which helps us track overlapping ranges, and what stages belong into them. It will be used in thepush_constantscommand to help fixing some issues regarding:And also solidify the implementation.
CHANGELOG: