Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support for VK_KHR_portability_subset Devices #1927

Merged
merged 4 commits into from
Jul 18, 2022
Merged

Support for VK_KHR_portability_subset Devices #1927

merged 4 commits into from
Jul 18, 2022

Conversation

AustinJ235
Copy link
Member

Adds support for VK_KHR_portability_subset devices.

Changelog:

- **Breaking** Removed `DeviceExtensions::required_extensions()`
- **Breaking** Removed `PhysicalDevice::required_extensions()`
- `InstanceCreateInfo` now has `enumerate_portability` field.

Automatically enable khr_portability_subset on Device; Remove required_extensions from PhysicalDevice & Device
@Rua
Copy link
Contributor

Rua commented Jul 18, 2022

What should Vulkano do with the enumerate_portability field if the khr_portability_enumeration extension isn't available? The previous default behaviour, before the extension was introduced, was equivalent to setting it to true. Should Vulkano enforce that the flag is always true for such cases, or should we explicitly document that Vulkan(o) behaves as if it's set to true and the user-set value is ignored?

@AustinJ235
Copy link
Member Author

What should Vulkano do with the enumerate_portability field if the khr_portability_enumeration extension isn't available? The previous default behaviour, before the extension was introduced, was equivalent to setting it to true. Should Vulkano enforce that the flag is always true for such cases, or should we explicitly document that Vulkan(o) behaves as if it's set to true and the user-set value is ignored?

Documentation add with a6843ef

@Rua Rua merged commit df97b2c into vulkano-rs:master Jul 18, 2022
Rua added a commit that referenced this pull request Jul 18, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants