Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add sparse image querying functions #1968

Merged
merged 1 commit into from
Sep 11, 2022
Merged

Add sparse image querying functions #1968

merged 1 commit into from
Sep 11, 2022

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Sep 10, 2022

Changelog:

- Added two missing functions for querying about sparse images: `PhysicalDevice::sparse_image_format_properties` and `UnsafeImage::sparse_memory_requirements`.

These functions from Vulkan 1.0 were still missing, so this implements them. They'll be useful if anyone ever wants to implement sparse images properly.

I also moved some of the new types from the physical module to more appropriate places.

AustinJ235
AustinJ235 approved these changes Sep 11, 2022
View reviewed changes
Copy link
Member

@AustinJ235 AustinJ235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AustinJ235 AustinJ235 merged commit f82d13a into vulkano-rs:master Sep 11, 2022
AustinJ235 added a commit that referenced this pull request Sep 11, 2022
@AustinJ235
#1968 Changelog
3878462
@Rua Rua deleted the sparse-image branch September 17, 2022 11:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@AustinJ235 AustinJ235 AustinJ235 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rua @AustinJ235