Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix handling of runtime sized arrays in shaders #1992

Merged
merged 2 commits into from
Sep 22, 2022
Merged

Fix handling of runtime sized arrays in shaders #1992

merged 2 commits into from
Sep 22, 2022

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Sep 19, 2022 •
edited
Loading

Changelog:

- Bugs fixed:
  - Incorrect check for descriptor set validity when the shader declares a runtime-sized array.

Reported on Discord by @winterle.

AustinJ235
AustinJ235 approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@AustinJ235 AustinJ235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the investigation/fix.

@AustinJ235 AustinJ235 merged commit 9a50d6c into vulkano-rs:master Sep 22, 2022
AustinJ235 added a commit that referenced this pull request Sep 22, 2022
@AustinJ235
#1992 Changelog
d586339
@Rua Rua deleted the descriptor-count-fix branch October 4, 2022 08:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@AustinJ235 AustinJ235 AustinJ235 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rua @AustinJ235