Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
This is a first step in reorganising the futures so that the
Queue
can eventually own and keep track of everything that is submitted to it, similar to whatCommandBufferBuilder
already does. The hope is that this will eventually make it possible to implement a lot of currently missing features and fix some of the issues currently plaguing futures. In this PR, the most important underlying change is the addition of three new unchecked methods (currentlypub(crate)
only) toQueue
, and making the existing future code use those methods internally, including the new info structs I created for them.