Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add new memory property flags and improve documentation #2005

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Add new memory property flags and improve documentation #2005

merged 2 commits into from
Sep 27, 2022

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Sep 26, 2022

Changelog:

### Additions
- Added the `device_coherent`, `device_uncached` and `rdma_capable` flags to `MemoryPropertyFlags`, and improved the documentation of all flags with additional usage advice.

Following discussion in Discord.

AustinJ235
AustinJ235 approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@AustinJ235 AustinJ235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@AustinJ235 AustinJ235 merged commit 40642f6 into vulkano-rs:master Sep 27, 2022
AustinJ235 added a commit that referenced this pull request Sep 27, 2022
@AustinJ235
#2005 Changelog
9d0a205
@Rua Rua deleted the memory-property-flags branch October 4, 2022 08:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@AustinJ235 AustinJ235 AustinJ235 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rua @AustinJ235