Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

#1935 add from_handle to DeviceMemory #2011

Merged
merged 2 commits into from
Oct 2, 2022
Merged

Conversation

hsteinmueller
Copy link
Contributor

Added from_handle constructor to DeviceMemory, see #1938.

I also tried to add the constructor to Instance and Device but I couldn't find a nice solution without refactoring too much.
If you could maybe provide a suggestion or hint, I might be able to add it for those too.

@Rua
Copy link
Contributor

Rua commented Oct 1, 2022

Looks good! A while back, I changed the order of the parameters so that device is first, and made some changes to the documentation. Can you change that here, so that it matches the others?

@hsteinmueller
Copy link
Contributor Author

Looks good! A while back, I changed the order of the parameters so that device is first, and made some changes to the documentation. Can you change that here, so that it matches the others?

I missed that sorry. I also removed the call from allocate with the unnecessary unsafe.

@Rua Rua merged commit 75ef521 into vulkano-rs:master Oct 2, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants