Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rename internal_object to handle #2037

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Rename internal_object to handle #2037

merged 2 commits into from
Oct 20, 2022

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Oct 13, 2022

Changelog:

### Breaking changes
Changes to the `VulkanObject` trait:
- The method `internal_object` is renamed to `handle`, and the associated type `Object` is renamed to `Handle`.

This is something I've been wanting to do for a while. In Vulkan terminology these are "handles" and we already use that terminology elsewhere: the private variables holding them are called handle and we have from_handle constructors now too.

Copy link
Member

@AustinJ235 AustinJ235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, needs some conflicts addressed. You can go ahead with the merge when those are resolved.

@marc0246
Copy link
Contributor

I love this too, has been bothering me for a while haha!

@Rua Rua merged commit b923001 into vulkano-rs:master Oct 20, 2022
Rua added a commit that referenced this pull request Oct 20, 2022
@Rua Rua deleted the vulkanobject branch December 6, 2022 11:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants