Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add async future for Fence Signal #2051

Merged
merged 2 commits into from
Oct 29, 2022
Merged

Add async future for Fence Signal #2051

merged 2 commits into from
Oct 29, 2022

Conversation

Joeoc2001
Copy link
Contributor

Changelog:

### Additions
- Add a spinning Future implementation to FenceSignalFuture.

Allows Fence futures to be .awaited by spinning. This is better than blocking in async applications since the async engine used can choose to progress some other future while the work for the fence is being completed on the GPU.

Resolves #1412

@Rua
Copy link
Contributor

Rua commented Oct 28, 2022

Would it make sense to include this directly on Fence as well?

@Joeoc2001
Copy link
Contributor Author

Would it make sense to include this directly on Fence as well?

Sure, I'll do that now

@Joeoc2001
Copy link
Contributor Author

@Rua done

@Rua
Copy link
Contributor

Rua commented Oct 29, 2022

Thanks, looks good now!

@Rua Rua merged commit b8245db into vulkano-rs:master Oct 29, 2022
Rua added a commit that referenced this pull request Oct 29, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GpuFuture and Future
2 participants