Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor reporting of resources used in command buffers #2091

Merged
merged 1 commit into from
Nov 20, 2022

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Nov 19, 2022

Changelog:

### Breaking changes
Changes to `GpuFuture`:
- The `check_buffer_access` and `check_image_access` methods now return nothing on success.

Changes to pipelines:
- The `descriptor_binding_requirements` method is moved to the `Pipeline` trait, and returns a reference to the hashmap directly.

This is mostly an internal refactoring, with a few user-visible changes on the side. Where previously, strings were used to indicate which resource within a command was being indicated in an error message, there is now the ResourceUseRef type which indicates it structurally.

@AustinJ235 AustinJ235 merged commit 4e85ce5 into vulkano-rs:master Nov 20, 2022
AustinJ235 added a commit that referenced this pull request Nov 20, 2022
@Rua Rua deleted the ResourceUseRef branch December 6, 2022 11:22
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants