Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Generate device properties that are alignment as DeviceAlignment #2155

Merged
merged 6 commits into from
Mar 15, 2023

Conversation

marc0246
Copy link
Contributor

This makes it easier to safely and efficiently work with alignments, because we and the user don't need to convert these properties to the type the new APIs expect. I also moved DeviceAlignment to a different file while it hasn't been released, because I felt I misplaced it the first time around.

Changelog:

### Breaking changes
- Device properties that represent alignments are now generated with the type `DeviceAlignment` instead of `DeviceSize`.

@Rua Rua merged commit 127b3ea into vulkano-rs:master Mar 15, 2023
@marc0246 marc0246 deleted the device-alignment branch March 15, 2023 21:22
Rua added a commit that referenced this pull request Mar 15, 2023
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
…ulkano-rs#2155)

* Move `DeviceAlignment`

* Generate alignment-properties with the type `DeviceAlignment`

* Small fix

* Another small fix

* Switch to using `is_aligned` where possible

* Oopsie
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants