-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Refactor AllocationCreateInfo
#2174
Refactor AllocationCreateInfo
#2174
Conversation
I see two other options for
|
If the user can override the size, then that would cause issues if it's smaller than required for |
Let's go with that then. I think requiring a fixed value, especially one that is otherwise disallowed, is better than just ignoring the value. It allows us to change our mind later. |
Yes, I very much agree. That's what is currenly in the code, except that the requirement for it to be zero is only a |
Yeah I think a full assert would be better. |
Alrighty done. |
* Refactor `AllocationCreateInfo` * `debug_assert` -> `assert`
This refactors
AllocationCreateInfo
such that it can be used together withBufferCreateInfo
and, in the future,ImageCreateInfo
, to construct buffers and images, removingBufferAllocateInfo
. Doing this before users start using this API in 0.33.What is still unresolved is whether ignoring
BufferCreateInfo::size
when in these constructor functions is the right way.Changelog:
Add: