Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Require explicit VertexInputState creation #2183

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Require explicit VertexInputState creation #2183

merged 1 commit into from
Apr 19, 2023

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Apr 19, 2023 •
edited
Loading

Changelog:

### Breaking changes
Changes to shaders and pipelines:
- `GraphicsPipelineBuilder::vertex_input_state` now requires a `VertexInputState` object directly, instead of a `VertexDefinition`. The `VertexDefinition` trait can be used to create the object.

This makes things a bit more explicit, and also eliminates the last type parameter from the builder.

After this, I intend to give the pipeline layout the same treatment, but while still allowing the user to auto-create it if they really want to.

@marc0246 marc0246 merged commit 958a725 into vulkano-rs:master Apr 19, 2023
marc0246 added a commit that referenced this pull request Apr 19, 2023
@marc0246
#2183 changelog
b61adb8
@Rua Rua deleted the vertex-input branch October 25, 2023 14:25
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
@Rua @hakolao
Require explicit VertexInputState creation (vulkano-rs#2183)
045edb3
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
@marc0246 @hakolao
vulkano-rs#2183 changelog
f2986cc
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rua @marc0246