Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Mildly optimize RangeMap #2189

Merged
merged 1 commit into from
Apr 23, 2023
Merged

Conversation

marc0246
Copy link
Contributor

Following are the results of my benchmarks before and after:

test tests::descriptor_set    ... bench:  96,200,265 ns/iter (+/- 3,663,596)
test tests::dispatch_indirect ... bench:  86,317,442 ns/iter (+/- 1,821,521)
test tests::descriptor_set    ... bench:  67,867,435 ns/iter (+/- 1,519,747)
test tests::dispatch_indirect ... bench:  64,132,526 ns/iter (+/- 875,303)

Nothing spectacular unfortunately. I removed the Gaps iterator because I didn't have the mental capacity to re-imlement it with the new ways the ranges are stored, but I doubt we'll ever need that one anyway.

@Rua
Copy link
Contributor

Rua commented Apr 23, 2023

Still a welcome improvement, thanks!

@Rua Rua merged commit 2e414bb into vulkano-rs:master Apr 23, 2023
@marc0246 marc0246 deleted the rangemap-optimization branch April 23, 2023 19:54
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants