Remove needless unsafe from Buffer::from_{data,iter}
#2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This must have been some relic that was never touched while things around it were refactored. I'm positive this unsafe is not needed and it might confuse users that are looking at how the library does things. I also checked the assembly and there's no change it seems.
It might be worth investigating why the assembly is so bloated but that's a different issue. Switching from an owned array to a borrowed one as the source makes it generate a memcpy. Note that in the throughput measurements I did in #2076, a memcpy was actually slightly slower than no memcpy, so that's something to consider as we're working with mapped memory and things don't always work as expected.