ValidationError-ify `Surface` and `Swapchain` #2236

Rua · 2023-06-24T12:52:54Z

Changelog:

### Breaking changes
Changes to `Swapchain`:
- Swapchain creation no longer returns an error when the swapchain extent doesn't match the current surface extent. This requirement is ill-defined in the spec, as detailed here: [TOCTOU race condition on minImageExtent/maxImageExtent?](https://github.com/KhronosGroup/Vulkan-Docs/issues/1144).

### Additions
- Support for the `ext_surface_maintenance1` and most of the `ext_swapchain_maintenance1` extension.

Depends on #2233. I also reorganised the swapchain code a bit, by placing the main Swapchain type and related things in swapchain/mod.rs, and splitting off the acquire/present stuff into swapchain/acquire_present.rs.

Items of ext_swapchain_maintenance1 that are still missing:

- `vkReleaseSwapchainImagesEXT` / `VkReleaseSwapchainImagesInfoEXT`
- `VkSwapchainPresentFenceInfoEXT`

Both of these rely on proper (queue) sync logic, which we don't have yet.

…tures

…wapchain-validation

marc0246

The merge is incomplete, these should be gone now.

vulkano/src/lib.rs

Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com>

marc0246 · 2023-06-25T18:12:33Z

Yes hello, I'd like to order one merge please.

…wapchain-validation

…apchain-validation

marc0246 · 2023-06-25T18:22:31Z

Hmm, I think you need to unununfix that.

Rua · 2023-06-25T18:23:49Z

I don't know what the right way is anymore @.@

marc0246 · 2023-06-25T18:26:24Z

Hehe

examples/src/bin/simple-particles.rs

marc0246

My understanding was that these being the first thing in the handler was intentional, as it makes no sense to render to a window that's minimized. Moreover, you moved these checks inside the if below but not in all examples, so that's inconsistent now and makes me one sad boii.

examples/src/bin/async-update.rs

examples/src/bin/buffer-allocator.rs

examples/src/bin/clear_attachments.rs

examples/src/bin/deferred/main.rs

examples/src/bin/image-self-copy-blit/main.rs

examples/src/bin/occlusion-query.rs

examples/src/bin/push-descriptors/main.rs

examples/src/bin/runtime_array/main.rs

examples/src/bin/texture_array/main.rs

examples/src/bin/triangle-v1_3.rs

marc0246 · 2023-06-26T09:17:46Z

Thanks!

* Add `RequiresAllOf`, automatically enable required extensions and features * Add more missing backticks and backslashes to error messages * Use updated VUIDs that require `acceleration_structure` * ValidationError-ify `Surface` and `Swapchain` * Update vulkano/src/lib.rs Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com> * Update vulkano/src/lib.rs Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com> * Don't draw if the window has zero size --------- Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com>

Rua added 5 commits June 18, 2023 09:37

Add RequiresAllOf, automatically enable required extensions and fea…

2a64ccc

…tures

Add more missing backticks and backslashes to error messages

3c06bd9

Use updated VUIDs that require acceleration_structure

7c14786

ValidationError-ify Surface and Swapchain

2eedca3

Merge branch 'master' of https://github.com/vulkano-rs/vulkano into s…

26c0137

…wapchain-validation

marc0246 reviewed Jun 25, 2023

View reviewed changes

vulkano/src/lib.rs Outdated Show resolved Hide resolved

vulkano/src/lib.rs Outdated Show resolved Hide resolved

Rua and others added 2 commits June 25, 2023 17:48

Update vulkano/src/lib.rs

06f89bf

Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com>

Update vulkano/src/lib.rs

8e02bbd

Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com>

Rua added 2 commits June 25, 2023 20:19

Merge branch 'master' of https://github.com/vulkano-rs/vulkano into s…

2d249e1

…wapchain-validation

Merge branch 'swapchain-validation' of github.com:Rua/vulkano into sw…

d2370bc

…apchain-validation

Rua force-pushed the swapchain-validation branch from 0234551 to d2370bc Compare June 25, 2023 18:24

marc0246 reviewed Jun 25, 2023

View reviewed changes

examples/src/bin/simple-particles.rs Outdated Show resolved Hide resolved

marc0246 reviewed Jun 25, 2023

View reviewed changes

Don't draw if the window has zero size

0b62ec4

Rua force-pushed the swapchain-validation branch from f66b56d to 0b62ec4 Compare June 26, 2023 07:55

marc0246 merged commit da09477 into vulkano-rs:master Jun 26, 2023

marc0246 added a commit that referenced this pull request Jun 26, 2023

#2236 changelog

0b9bca6

Rua deleted the swapchain-validation branch October 25, 2023 14:25

tronical mentioned this pull request Nov 5, 2023

App crashes with skia vulkan renderer slint-ui/slint#3850

Closed

hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024

vulkano-rs#2236 changelog

a509195

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ValidationError-ify `Surface` and `Swapchain` #2236

ValidationError-ify `Surface` and `Swapchain` #2236

Rua commented Jun 24, 2023

marc0246 left a comment

marc0246 commented Jun 25, 2023

marc0246 commented Jun 25, 2023

Rua commented Jun 25, 2023

marc0246 commented Jun 25, 2023

marc0246 left a comment

marc0246 commented Jun 26, 2023

ValidationError-ify Surface and Swapchain #2236

ValidationError-ify Surface and Swapchain #2236

Conversation

Rua commented Jun 24, 2023

marc0246 left a comment

Choose a reason for hiding this comment

marc0246 commented Jun 25, 2023

marc0246 commented Jun 25, 2023

Rua commented Jun 25, 2023

marc0246 commented Jun 25, 2023

marc0246 left a comment

Choose a reason for hiding this comment

marc0246 commented Jun 26, 2023

ValidationError-ify `Surface` and `Swapchain` #2236

ValidationError-ify `Surface` and `Swapchain` #2236