Wrap buffer values in AccelerationStructureBuildGeometryInfo in an Option
#2307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
|
Having |
|
It works as a default value, but I was concerned that forcing the user to choose a mode when they may not know the mode yet, would be a problem. I can undo that if you prefer. |
|
AFAIK you just leave it at build because the field is ignored anyway, and build happens to have |
|
Rather the other way around -- you leave it at |
|
Thanks! |
marc0246
added a commit
to marc0246/vulkano
that referenced
this pull request
Aug 26, 2023
hakolao
pushed a commit
to hakolao/vulkano
that referenced
this pull request
Feb 20, 2024
…`Option` (vulkano-rs#2307) * Wrap buffer values in `AccelerationStructureBuildGeometryInfo` in an `Option` * Oops! * Also wrap `mode` and `dst_acceleration_structure` * Un-wrap mode
hakolao
pushed a commit
to hakolao/vulkano
that referenced
this pull request
Feb 20, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2304.