Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make GenericMemoryAllocatorCreateInfo::block_sizes more flexible #2319

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

marc0246
Copy link
Contributor

@marc0246 marc0246 commented Sep 7, 2023

Changelog:

### Breaking changes
Changes to memory allocation:
- `GenericMemoryAllocatorCreateInfo::block_sizes` now represents a block size per memory type, instead of per memory heap, to allow for a more fine-grained configuration.

There wasn't really any reason block sizes would have to be restricted to the level of heaps. Apart from the added flexibility this also makes the code cleaner. I also merged the two lifetimes GenericMemoryAllocatorCreateInfo into one as I don't think it's needed, and replaced the use of ash::vk::MemoryPropertyFlags with our own. This was originally the ash type because before #2073, the ArrayVec would have taken up a huge amount of space, and would need a costly conversion to the bitfield anyway.

@Rua Rua merged commit aecb7a4 into vulkano-rs:master Sep 13, 2023
Rua added a commit that referenced this pull request Sep 13, 2023
@marc0246 marc0246 deleted the block-sizes branch September 14, 2023 00:51
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants