Fix overlapping attributes when using dualSrcBlend
feature
#2333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update documentation to reflect any user-facing changes - in this repository.
N/A, it was an internal bug
Make sure that the changes are covered by unit-tests.
Looks like shader module as a whole is missing unit tests :<
Run
cargo fmt
on the changes.Please put changelog entries in the description of this Pull Request
if knowledge of this change could be valuable to users. No need to put the
entries to the changelog directly, they will be transferred to the changelog
file by maintainers right after the Pull Request merge.
Please remove any items from the template below that are not applicable.
Describe in common words what is the purpose of this change, related
Github Issues, and highlight important implementation aspects.
This change allows for fragment shaders to make use of the
dualSrcBlend
feature of Vulkan 1.0, by assigning anindex
layout to color outputs. In vulkano 0.33.0, this causes a compile time error, and in the currentmaster
branch it causes a runtime error, due to detection of overlapping interface variables not takingindex
into account. This fixes that :>Changelog: