Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Make dynamic state future-proof and more Vulkan-y #2348

Merged
merged 8 commits into from
Oct 7, 2023
Merged

Make dynamic state future-proof and more Vulkan-y #2348

merged 8 commits into from
Oct 7, 2023

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Oct 6, 2023

Changelog:

### Breaking changes
Changes to pipeline construction:
- Dynamic state is now specified with the `GraphicsPipelineCreateInfo::dynamic_state` field.

marc0246
marc0246 reviewed Oct 7, 2023
View reviewed changes
vulkano/src/pipeline/graphics/color_blend.rs Outdated Show resolved Hide resolved
vulkano/src/pipeline/graphics/depth_stencil.rs Outdated Show resolved Hide resolved
vulkano/src/pipeline/graphics/depth_stencil.rs Outdated Show resolved Hide resolved
vulkano/src/pipeline/graphics/discard_rectangle.rs Outdated Show resolved Hide resolved
vulkano/src/pipeline/graphics/input_assembly.rs Outdated Show resolved Hide resolved
vulkano/src/pipeline/graphics/multisample.rs Outdated Show resolved Hide resolved
vulkano/src/pipeline/graphics/rasterization.rs Outdated Show resolved Hide resolved
vulkano/src/pipeline/graphics/tessellation.rs Outdated Show resolved Hide resolved
vulkano/src/pipeline/graphics/viewport.rs Outdated Show resolved Hide resolved
@marc0246
Copy link
Contributor

marc0246 commented Oct 7, 2023

Very nice work!

@marc0246 marc0246 merged commit 0fed9bb into vulkano-rs:master Oct 7, 2023
3 checks passed
marc0246 added a commit that referenced this pull request Oct 7, 2023
@marc0246
#2348 changelog
4523ff0
@Rua Rua deleted the dynamic-state branch October 25, 2023 14:24
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
@Rua @hakolao
Make dynamic state future-proof and more Vulkan-y (vulkano-rs#2348)
14b7ae7 
* Make dynamic state future-proof and more Vulkan-y

* Additional fixes

* Extra docs

* Oops

* Derp!

* Review fixes
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
@marc0246 @hakolao
vulkano-rs#2348 changelog
7f8ce85
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@marc0246 marc0246 marc0246 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rua @marc0246