Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add DeviceAddress, handle pointers as SPIR-V struct members #2351

Merged
merged 3 commits into from
Oct 7, 2023
Merged

Add DeviceAddress, handle pointers as SPIR-V struct members #2351

merged 3 commits into from
Oct 7, 2023

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Oct 7, 2023

Changelog:

### Additions
- Added the `DeviceAddress` and `NonNullDeviceAddress` types to the crate root.

### Bugs fixed
- Vulkano-shaders: handle pointers correctly when they appear in composite types.

Fixes a bug reported by @hYdos on Discord.

@Rua Rua marked this pull request as ready for review October 7, 2023 12:35
@marc0246 marc0246 merged commit 0175bcd into vulkano-rs:master Oct 7, 2023
3 checks passed
marc0246 added a commit that referenced this pull request Oct 7, 2023
@marc0246
#2351 changelog
5a98b0b
@Rua Rua mentioned this pull request Oct 8, 2023
Merged
@Rua Rua deleted the device-address branch October 25, 2023 14:24
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
@Rua @hakolao
Add DeviceAddress, handle pointers as SPIR-V struct members (vulkan…
3f005df 
…o-rs#2351)

* Add `DeviceAddress`, handle pointers as SPIR-V struct members

* Add pointers to vulkano-shaders
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
@marc0246 @hakolao
vulkano-rs#2351 changelog
48f92bb
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rua @marc0246