Add remaining ext_descriptor_indexing flags
#2358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase please? |
…escriptor-indexing
hakolao
pushed a commit
to hakolao/vulkano
that referenced
this pull request
Feb 20, 2024
* Fix the documentation for `DescriptorPool` methods * Pool allocate validation * Add `DescriptorPoolAlloc`, make `UnsafeDescriptorSet` more useful * Add remaining `ext_descriptor_indexing` flags
hakolao
pushed a commit
to hakolao/vulkano
that referenced
this pull request
Feb 20, 2024
hakolao
pushed a commit
to hakolao/vulkano
that referenced
this pull request
Feb 20, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
Depends on #2357. Closes #1706.
This completes coverage of the
ext_descriptor_indexingextension for Vulkan 1.2, but with some caveats. The newDescriptorBindingFlagsare pretty much useless at the moment, because Vulkano doesn't support updating descriptor sets after they're created, and because the draw-time checks don't handle dynamic use yet. However, at least the flags now exist and are properly validated, so that doesn't have to be done later.DescriptorSetLayoutCreateFlags::UPDATE_AFTER_BIND_POOLis useful for getting the increased limits.