Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add a StandardDescriptorSetAllocatorCreateInfo #2366

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

marc0246
Copy link
Contributor

Fixes an oversight in the original implementation where the number of sets allocated was hard-coded, which would lead to huge memory usage with large descriptor sets (e.g. bindless). The idea is that for bindless, the user would set the set count to 1. They will still need to do manual garbage collection for pools of old descriptor set layouts, and ideally there would be a better solution for bindless specifically, but for now this should do.

Changelog:

### Breaking changes
- `StandardDescriptorSetAllocator` now takes a `StandardDescriptorSetAllocatorCreateInfo` parameter.

@marc0246 marc0246 changed the title Descriptor set allocator create info Add a StandardDescriptorSetAllocatorCreateInfo Oct 24, 2023
@Rua Rua merged commit ac2a83b into vulkano-rs:master Oct 24, 2023
3 checks passed
Rua added a commit that referenced this pull request Oct 24, 2023
@marc0246 marc0246 deleted the descriptor-set-allocator-create-info branch October 24, 2023 14:25
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
* Add `StandardDescriptorSetAllocatorCreateInfo`

* Fix tests and examples
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants