Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Trying to debug a bug that only happens in CI... fun #2386

Closed
wants to merge 6 commits into from

Conversation

marc0246
Copy link
Contributor

No description provided.

@marc0246 marc0246 force-pushed the proc-macro-crate-2.0 branch 3 times, most recently from 35fe4a8 to f352dc2 Compare October 31, 2023 02:12
@marc0246
Copy link
Contributor Author

The environment variables all seem fine. I really can't fathom what could be different about the environment in the CI compared to my local environment.

@marc0246 marc0246 force-pushed the proc-macro-crate-2.0 branch from 9983ce7 to c50c4dc Compare November 1, 2023 17:56
@marc0246
Copy link
Contributor Author

marc0246 commented Nov 1, 2023

At least we can update proc-macro-crate now as of #2391, but that still doesn't answer why proc-macro-crate would fail with having an extra workspace, and only since 2.0, and only with certain examples, and different ones between the OSes...

@marc0246
Copy link
Contributor Author

marc0246 commented Nov 1, 2023

Turns out, since proc-macro-crate 2.0, it spawns is own cargo process. Because our examples/Cargo.toml was misconfigured, and didn't exclude examples/target from the examples workspace, this would cause that spawned cargo process to error out.

That said, the way this manifested itself is extremely non-obvious. proc-macro-crate should print cargo's stderr, instead of returning its stdout which is the empty string you can see in the first commit's CI runs. I guess the platform differences are due cargo behaving slightly differently between them and compiling them in a different order/parellelizing differently.

@marc0246 marc0246 closed this Nov 1, 2023
@marc0246 marc0246 deleted the proc-macro-crate-2.0 branch November 1, 2023 19:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant