-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Unexport client field #168
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mamclaughlin travis is having issues - will need to look into that I ran the tests off my branch locally ☁ govultr [unexport-client-field] go test ./... -v -race
=== RUN TestAccountServiceHandler_Get
--- PASS: TestAccountServiceHandler_Get (0.00s)
=== RUN TestApplicationServiceHandler_List
--- PASS: TestApplicationServiceHandler_List (0.00s)
=== RUN TestBackupServiceHandler_List
--- PASS: TestBackupServiceHandler_List (0.00s)
=== RUN TestBackupServiceHandler_ListEmpty
--- PASS: TestBackupServiceHandler_ListEmpty (0.00s)
=== RUN TestBackupServiceHandler_Get
--- PASS: TestBackupServiceHandler_Get (0.00s)
=== RUN TestBackupServiceHandler_GetEmpty
--- PASS: TestBackupServiceHandler_GetEmpty (0.00s)
=== RUN TestBareMetalServerServiceHandler_GetServer
--- PASS: TestBareMetalServerServiceHandler_GetServer (0.00s)
=== RUN TestBareMetalServerServiceHandler_Create
--- PASS: TestBareMetalServerServiceHandler_Create (0.00s)
=== RUN TestBareMetalServerServiceHandler_Update
--- PASS: TestBareMetalServerServiceHandler_Update (0.00s)
=== RUN TestBareMetalServerServiceHandler_Delete
--- PASS: TestBareMetalServerServiceHandler_Delete (0.00s)
=== RUN TestBareMetalServerServiceHandler_List
--- PASS: TestBareMetalServerServiceHandler_List (0.00s)
=== RUN TestBareMetalServerServiceHandler_GetBandwidth
--- PASS: TestBareMetalServerServiceHandler_GetBandwidth (0.00s)
=== RUN TestBareMetalServerServiceHandler_Halt
--- PASS: TestBareMetalServerServiceHandler_Halt (0.00s)
=== RUN TestBareMetalServerServiceHandler_ListIPv4s
--- PASS: TestBareMetalServerServiceHandler_ListIPv4s (0.00s)
=== RUN TestBareMetalServerServiceHandler_ListIPv6s
--- PASS: TestBareMetalServerServiceHandler_ListIPv6s (0.00s)
=== RUN TestBareMetalServerServiceHandler_Reboot
--- PASS: TestBareMetalServerServiceHandler_Reboot (0.00s)
=== RUN TestBareMetalServerServiceHandler_Reinstall
--- PASS: TestBareMetalServerServiceHandler_Reinstall (0.00s)
=== RUN TestBareMetalServerServiceHandler_Start
--- PASS: TestBareMetalServerServiceHandler_Start (0.00s)
=== RUN TestBareMetalServerServiceHandler_GetUserData
--- PASS: TestBareMetalServerServiceHandler_GetUserData (0.00s)
=== RUN TestBareMetalServerServiceHandler_GetUpgrades
--- PASS: TestBareMetalServerServiceHandler_GetUpgrades (0.00s)
=== RUN TestBareMetalServerServiceHandler_GetVNCUrl
--- PASS: TestBareMetalServerServiceHandler_GetVNCUrl (0.00s)
=== RUN TestBareMetalServerServiceHandler_MassStart
--- PASS: TestBareMetalServerServiceHandler_MassStart (0.00s)
=== RUN TestBareMetalServerServiceHandler_MassReboot
--- PASS: TestBareMetalServerServiceHandler_MassReboot (0.00s)
=== RUN TestBareMetalServerServiceHandler_MassHalt
--- PASS: TestBareMetalServerServiceHandler_MassHalt (0.00s)
=== RUN TestBareMetalServerServiceHandler_CreateMarketplaceImage
--- PASS: TestBareMetalServerServiceHandler_CreateMarketplaceImage (0.00s)
=== RUN TestBlockStorageServiceHandler_Create
--- PASS: TestBlockStorageServiceHandler_Create (0.00s)
=== RUN TestBlockStorageServiceHandler_Get
--- PASS: TestBlockStorageServiceHandler_Get (0.00s)
=== RUN TestBlockStorageServiceHandler_Update
--- PASS: TestBlockStorageServiceHandler_Update (0.00s)
=== RUN TestBlockStorageServiceHandler_Delete
--- PASS: TestBlockStorageServiceHandler_Delete (0.00s)
=== RUN TestBlockStorageServiceHandler_List
--- PASS: TestBlockStorageServiceHandler_List (0.00s)
=== RUN TestBlockStorageServiceHandler_Attach
--- PASS: TestBlockStorageServiceHandler_Attach (0.00s)
=== RUN TestBlockStorageServiceHandler_Detach
--- PASS: TestBlockStorageServiceHandler_Detach (0.00s)
=== RUN TestDomainRecordsServiceHandler_Create
--- PASS: TestDomainRecordsServiceHandler_Create (0.00s)
=== RUN TestDomainRecordsServiceHandler_Get
--- PASS: TestDomainRecordsServiceHandler_Get (0.00s)
=== RUN TestDomainRecordsServiceHandler_Update
--- PASS: TestDomainRecordsServiceHandler_Update (0.00s)
=== RUN TestDomainRecordsServiceHandler_Delete
--- PASS: TestDomainRecordsServiceHandler_Delete (0.00s)
=== RUN TestDomainRecordsServiceHandler_List
--- PASS: TestDomainRecordsServiceHandler_List (0.00s)
=== RUN TestDomainServiceHandler_Create
--- PASS: TestDomainServiceHandler_Create (0.00s)
=== RUN TestDomainServiceHandler_Get
--- PASS: TestDomainServiceHandler_Get (0.00s)
=== RUN TestDomainServiceHandler_Update
--- PASS: TestDomainServiceHandler_Update (0.00s)
=== RUN TestDomainServiceHandler_Delete
--- PASS: TestDomainServiceHandler_Delete (0.00s)
=== RUN TestDNSDomainServiceHandler_List
--- PASS: TestDNSDomainServiceHandler_List (0.00s)
=== RUN TestDomainServiceHandler_GetSoa
--- PASS: TestDomainServiceHandler_GetSoa (0.00s)
=== RUN TestDNSDomainServiceHandler_UpdateSoa
--- PASS: TestDNSDomainServiceHandler_UpdateSoa (0.00s)
=== RUN TestDNSDomainServiceHandler_DNSSecInfo
--- PASS: TestDNSDomainServiceHandler_DNSSecInfo (0.00s)
=== RUN TestFireWallGroupServiceHandler_Create
--- PASS: TestFireWallGroupServiceHandler_Create (0.00s)
=== RUN TestFireWallGroupServiceHandler_Get
--- PASS: TestFireWallGroupServiceHandler_Get (0.00s)
=== RUN TestFireWallGroupServiceHandler_ChangeDescription
--- PASS: TestFireWallGroupServiceHandler_ChangeDescription (0.00s)
=== RUN TestFireWallGroupServiceHandler_Delete
--- PASS: TestFireWallGroupServiceHandler_Delete (0.00s)
=== RUN TestFireWallGroupServiceHandler_List
--- PASS: TestFireWallGroupServiceHandler_List (0.00s)
=== RUN TestFireWallRuleServiceHandler_Create
--- PASS: TestFireWallRuleServiceHandler_Create (0.00s)
=== RUN TestFireWallRuleServiceHandler_Delete
--- PASS: TestFireWallRuleServiceHandler_Delete (0.00s)
=== RUN TestFireWallRuleServiceHandler_List
--- PASS: TestFireWallRuleServiceHandler_List (0.00s)
=== RUN TestFireWallRuleServiceHandler_Get
--- PASS: TestFireWallRuleServiceHandler_Get (0.00s)
=== RUN TestNewClient
--- PASS: TestNewClient (0.00s)
=== RUN TestClient_DoWithContext
--- PASS: TestClient_DoWithContext (0.00s)
=== RUN TestClient_DoWithContextFailure
--- PASS: TestClient_DoWithContextFailure (1.34s)
=== RUN TestClient_DoWithContextError
--- PASS: TestClient_DoWithContextError (1.34s)
=== RUN TestClient_NewRequest
--- PASS: TestClient_NewRequest (0.00s)
=== RUN TestClient_SetBaseUrl
--- PASS: TestClient_SetBaseUrl (0.00s)
=== RUN TestClient_SetUserAgent
--- PASS: TestClient_SetUserAgent (0.00s)
=== RUN TestClient_SetRateLimit
--- PASS: TestClient_SetRateLimit (0.00s)
=== RUN TestClient_OnRequestCompleted
--- PASS: TestClient_OnRequestCompleted (0.00s)
=== RUN TestClient_SetRetryLimit
--- PASS: TestClient_SetRetryLimit (0.00s)
=== RUN TestNewRequest_badURI
--- PASS: TestNewRequest_badURI (0.00s)
=== RUN TestNewRequest_badBody
--- PASS: TestNewRequest_badBody (0.00s)
=== RUN TestRequest_InvalidCall
--- PASS: TestRequest_InvalidCall (0.00s)
=== RUN TestRequest_InvalidResponseBody
--- PASS: TestRequest_InvalidResponseBody (0.00s)
=== RUN TestServerServiceHandler_GetBackupSchedule
--- PASS: TestServerServiceHandler_GetBackupSchedule (0.00s)
=== RUN TestServerServiceHandler_SetBackupSchedule
--- PASS: TestServerServiceHandler_SetBackupSchedule (0.00s)
=== RUN TestServerServiceHandler_RestoreBackup
--- PASS: TestServerServiceHandler_RestoreBackup (0.00s)
=== RUN TestServerServiceHandler_Neighbors
--- PASS: TestServerServiceHandler_Neighbors (0.00s)
=== RUN TestServerServiceHandler_ListPrivateNetworks
--- PASS: TestServerServiceHandler_ListPrivateNetworks (0.00s)
=== RUN TestServerServiceHandler_GetUserData
--- PASS: TestServerServiceHandler_GetUserData (0.00s)
=== RUN TestServerServiceHandler_ListIPv4
--- PASS: TestServerServiceHandler_ListIPv4 (0.00s)
=== RUN TestServerServiceHandler_ListIPv6
--- PASS: TestServerServiceHandler_ListIPv6 (0.00s)
=== RUN TestServerServiceHandler_CreateIPv4
--- PASS: TestServerServiceHandler_CreateIPv4 (0.00s)
=== RUN TestServerServiceHandler_DestroyIPV4
--- PASS: TestServerServiceHandler_DestroyIPV4 (0.00s)
=== RUN TestServerServiceHandler_GetBandwidth
--- PASS: TestServerServiceHandler_GetBandwidth (0.00s)
=== RUN TestServerServiceHandler_ListReverseIPv6
--- PASS: TestServerServiceHandler_ListReverseIPv6 (0.00s)
=== RUN TestServerServiceHandler_DefaultReverseIPv4
--- PASS: TestServerServiceHandler_DefaultReverseIPv4 (0.00s)
=== RUN TestServerServiceHandler_DeleteReverseIPv6
--- PASS: TestServerServiceHandler_DeleteReverseIPv6 (0.00s)
=== RUN TestServerServiceHandler_CreateReverseIPv4
--- PASS: TestServerServiceHandler_CreateReverseIPv4 (0.00s)
=== RUN TestServerServiceHandler_CreateReverseIPv6
--- PASS: TestServerServiceHandler_CreateReverseIPv6 (0.00s)
=== RUN TestServerServiceHandler_Halt
--- PASS: TestServerServiceHandler_Halt (0.00s)
=== RUN TestServerServiceHandler_Start
--- PASS: TestServerServiceHandler_Start (0.00s)
=== RUN TestServerServiceHandler_Reboot
--- PASS: TestServerServiceHandler_Reboot (0.00s)
=== RUN TestServerServiceHandler_Reinstall
--- PASS: TestServerServiceHandler_Reinstall (0.00s)
=== RUN TestServerServiceHandler_Delete
--- PASS: TestServerServiceHandler_Delete (0.00s)
=== RUN TestServerServiceHandler_Create
--- PASS: TestServerServiceHandler_Create (0.00s)
=== RUN TestServerServiceHandler_List
--- PASS: TestServerServiceHandler_List (0.00s)
=== RUN TestServerServiceHandler_GetServer
--- PASS: TestServerServiceHandler_GetServer (0.00s)
=== RUN TestInstanceServiceHandler_GetUpgrades
--- PASS: TestInstanceServiceHandler_GetUpgrades (0.00s)
=== RUN TestServerServiceHandler_MassStart
--- PASS: TestServerServiceHandler_MassStart (0.00s)
=== RUN TestServerServiceHandler_MassReboot
--- PASS: TestServerServiceHandler_MassReboot (0.00s)
=== RUN TestServerServiceHandler_MassHalt
--- PASS: TestServerServiceHandler_MassHalt (0.00s)
=== RUN TestServerServiceHandler_AttachPrivateNetwork
--- PASS: TestServerServiceHandler_AttachPrivateNetwork (0.00s)
=== RUN TestServerServiceHandler_DetachPrivateNetwork
--- PASS: TestServerServiceHandler_DetachPrivateNetwork (0.00s)
=== RUN TestServerServiceHandler_ISOAttach
--- PASS: TestServerServiceHandler_ISOAttach (0.00s)
=== RUN TestServerServiceHandler_ISODetach
--- PASS: TestServerServiceHandler_ISODetach (0.00s)
=== RUN TestServerServiceHandler_ISO
--- PASS: TestServerServiceHandler_ISO (0.00s)
=== RUN TestServerServiceHandler_Update
--- PASS: TestServerServiceHandler_Update (0.00s)
=== RUN TestServerServiceHandler_CreateMarketplace
--- PASS: TestServerServiceHandler_CreateMarketplace (0.00s)
=== RUN TestIsoServiceHandler_Create
--- PASS: TestIsoServiceHandler_Create (0.00s)
=== RUN TestIsoServiceHandler_Get
--- PASS: TestIsoServiceHandler_Get (0.00s)
=== RUN TestIsoServiceHandler_Delete
--- PASS: TestIsoServiceHandler_Delete (0.00s)
=== RUN TestIsoServiceHandler_List
--- PASS: TestIsoServiceHandler_List (0.00s)
=== RUN TestIsoServiceHandler_ListPublic
--- PASS: TestIsoServiceHandler_ListPublic (0.00s)
=== RUN TestKubernetesHandler_CreateCluster
--- PASS: TestKubernetesHandler_CreateCluster (0.00s)
=== RUN TestKubernetesHandler_GetCluster
--- PASS: TestKubernetesHandler_GetCluster (0.00s)
=== RUN TestKubernetesHandler_ListClusters
--- PASS: TestKubernetesHandler_ListClusters (0.00s)
=== RUN TestKubernetesHandler_UpdateCluster
--- PASS: TestKubernetesHandler_UpdateCluster (0.00s)
=== RUN TestKubernetesHandler_DeleteCluster
--- PASS: TestKubernetesHandler_DeleteCluster (0.00s)
=== RUN TestKubernetesHandler_DeleteClusterWithResources
--- PASS: TestKubernetesHandler_DeleteClusterWithResources (0.00s)
=== RUN TestKubernetesHandler_CreateNodePool
--- PASS: TestKubernetesHandler_CreateNodePool (0.00s)
=== RUN TestKubernetesHandler_GetNodePool
--- PASS: TestKubernetesHandler_GetNodePool (0.00s)
=== RUN TestKubernetesHandler_ListNodePools
--- PASS: TestKubernetesHandler_ListNodePools (0.00s)
=== RUN TestKubernetesHandler_UpdateNodePool
--- PASS: TestKubernetesHandler_UpdateNodePool (0.00s)
=== RUN TestKubernetesHandler_DeleteNodePool
--- PASS: TestKubernetesHandler_DeleteNodePool (0.00s)
=== RUN TestKubernetesHandler_DeleteNodePoolInstance
--- PASS: TestKubernetesHandler_DeleteNodePoolInstance (0.00s)
=== RUN TestKubernetesHandler_RecycleNodePoolInstance
--- PASS: TestKubernetesHandler_RecycleNodePoolInstance (0.00s)
=== RUN TestKubernetesHandler_GetKubeConfig
--- PASS: TestKubernetesHandler_GetKubeConfig (0.00s)
=== RUN TestKubernetesHandler_GetVersions
--- PASS: TestKubernetesHandler_GetVersions (0.00s)
=== RUN TestLoadBalancerHandler_List
--- PASS: TestLoadBalancerHandler_List (0.00s)
=== RUN TestLoadBalancerHandler_Delete
--- PASS: TestLoadBalancerHandler_Delete (0.00s)
=== RUN TestLoadBalancerHandler_Get
--- PASS: TestLoadBalancerHandler_Get (0.00s)
=== RUN TestLoadBalancerHandler_ListForwardingRules
--- PASS: TestLoadBalancerHandler_ListForwardingRules (0.00s)
=== RUN TestLoadBalancerHandler_DeleteForwardingRule
--- PASS: TestLoadBalancerHandler_DeleteForwardingRule (0.00s)
=== RUN TestLoadBalancerHandler_CreateForwardingRule
--- PASS: TestLoadBalancerHandler_CreateForwardingRule (0.00s)
=== RUN TestLoadBalancerHandler_Create
--- PASS: TestLoadBalancerHandler_Create (0.00s)
=== RUN TestLoadBalancerHandler_Update
--- PASS: TestLoadBalancerHandler_Update (0.00s)
=== RUN TestLoadBalancerHandler_GetFowardingRule
--- PASS: TestLoadBalancerHandler_GetFowardingRule (0.00s)
=== RUN TestLoadBalancerHandler_GetFirewallRule
--- PASS: TestLoadBalancerHandler_GetFirewallRule (0.00s)
=== RUN TestMeta
--- PASS: TestMeta (0.00s)
=== RUN TestNetworkServiceHandler_Create
--- PASS: TestNetworkServiceHandler_Create (0.00s)
=== RUN TestNetworkServiceHandler_Delete
--- PASS: TestNetworkServiceHandler_Delete (0.00s)
=== RUN TestNetworkServiceHandler_List
--- PASS: TestNetworkServiceHandler_List (0.00s)
=== RUN TestNetworkServiceHandler_Update
--- PASS: TestNetworkServiceHandler_Update (0.00s)
=== RUN TestNetworkServiceHandler_Get
--- PASS: TestNetworkServiceHandler_Get (0.00s)
=== RUN TestObjectStorageServiceHandler_Create
--- PASS: TestObjectStorageServiceHandler_Create (0.00s)
=== RUN TestObjectStorageServiceHandler_Get
--- PASS: TestObjectStorageServiceHandler_Get (0.00s)
=== RUN TestObjectStorageServiceHandler_Update
--- PASS: TestObjectStorageServiceHandler_Update (0.00s)
=== RUN TestObjectStorageServiceHandler_Delete
--- PASS: TestObjectStorageServiceHandler_Delete (0.00s)
=== RUN TestObjectStorageServiceHandler_List
--- PASS: TestObjectStorageServiceHandler_List (0.00s)
=== RUN TestObjectStorageServiceHandler_ListCluster
--- PASS: TestObjectStorageServiceHandler_ListCluster (0.00s)
=== RUN TestObjectStorageServiceHandler_RegenerateKeys
--- PASS: TestObjectStorageServiceHandler_RegenerateKeys (0.00s)
=== RUN TestOSServiceHandler_List
--- PASS: TestOSServiceHandler_List (0.00s)
=== RUN TestPlanServiceHandler_List
--- PASS: TestPlanServiceHandler_List (0.00s)
=== RUN TestPlanServiceHandler_GetBareMetalList
--- PASS: TestPlanServiceHandler_GetBareMetalList (0.00s)
=== RUN TestRegionServiceHandler_List
--- PASS: TestRegionServiceHandler_List (0.00s)
=== RUN TestRegionServiceHandler_Availability
--- PASS: TestRegionServiceHandler_Availability (0.00s)
=== RUN TestReservedIPServiceHandler_Attach
--- PASS: TestReservedIPServiceHandler_Attach (0.00s)
=== RUN TestReservedIPServiceHandler_Convert
--- PASS: TestReservedIPServiceHandler_Convert (0.00s)
=== RUN TestReservedIPServiceHandler_Create
--- PASS: TestReservedIPServiceHandler_Create (0.00s)
=== RUN TestReservedIPServiceHandler_Delete
--- PASS: TestReservedIPServiceHandler_Delete (0.00s)
=== RUN TestReservedIPServiceHandler_Detach
--- PASS: TestReservedIPServiceHandler_Detach (0.00s)
=== RUN TestReservedIPServiceHandler_Get
--- PASS: TestReservedIPServiceHandler_Get (0.00s)
=== RUN TestReservedIPServiceHandler_List
--- PASS: TestReservedIPServiceHandler_List (0.00s)
=== RUN TestSnapshotServiceHandler_Create
--- PASS: TestSnapshotServiceHandler_Create (0.00s)
=== RUN TestSnapshotServiceHandler_CreateFromURL
--- PASS: TestSnapshotServiceHandler_CreateFromURL (0.00s)
=== RUN TestSnapshotServiceHandler_Get
--- PASS: TestSnapshotServiceHandler_Get (0.00s)
=== RUN TestSnapshotServiceHandler_Delete
--- PASS: TestSnapshotServiceHandler_Delete (0.00s)
=== RUN TestSnapshotServiceHandler_List
--- PASS: TestSnapshotServiceHandler_List (0.00s)
=== RUN TestSSHKeyServiceHandler_Create
--- PASS: TestSSHKeyServiceHandler_Create (0.00s)
=== RUN TestSSHKeyServiceHandler_Get
--- PASS: TestSSHKeyServiceHandler_Get (0.00s)
=== RUN TestSSHKeyServiceHandler_Update
--- PASS: TestSSHKeyServiceHandler_Update (0.00s)
=== RUN TestSSHKeyServiceHandler_Delete
--- PASS: TestSSHKeyServiceHandler_Delete (0.00s)
=== RUN TestSSHKeyServiceHandler_List
--- PASS: TestSSHKeyServiceHandler_List (0.00s)
=== RUN TestStartupScriptServiceHandler_Create
--- PASS: TestStartupScriptServiceHandler_Create (0.00s)
=== RUN TestStartupScriptServiceHandler_GET
--- PASS: TestStartupScriptServiceHandler_GET (0.00s)
=== RUN TestStartupScriptServiceHandler_Update
--- PASS: TestStartupScriptServiceHandler_Update (0.00s)
=== RUN TestStartupScriptServiceHandler_Delete
--- PASS: TestStartupScriptServiceHandler_Delete (0.00s)
=== RUN TestStartupScriptServiceHandler_List
--- PASS: TestStartupScriptServiceHandler_List (0.00s)
=== RUN TestUserServiceHandler_Create
--- PASS: TestUserServiceHandler_Create (0.00s)
=== RUN TestUserServiceHandler_Delete
--- PASS: TestUserServiceHandler_Delete (0.00s)
=== RUN TestUserServiceHandler_List
--- PASS: TestUserServiceHandler_List (0.00s)
=== RUN TestUserServiceHandler_Update
--- PASS: TestUserServiceHandler_Update (0.00s)
=== RUN TestUserServiceHandler_Get
--- PASS: TestUserServiceHandler_Get (0.00s)
PASS
ok github.com/vultr/govultr/v2 3.065s
? github.com/vultr/govultr/v2/cmd [no test files] |
mamclaughlin
approved these changes
Oct 20, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #167 it was pointed out that some of our client structs are exported while others are unexported. They should be unexported. Cleaning up the few that had been exported
Related Issues
#167
Checklist: