Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Amend license to give proper attribution #152

Merged
merged 3 commits into from
Apr 7, 2022
Merged

Amend license to give proper attribution #152

merged 3 commits into from
Apr 7, 2022

Conversation

vwxyzjn
Copy link
Owner

@vwxyzjn vwxyzjn commented Apr 6, 2022

Description

This PR gives proper attribution in the LICENSE, similar to how ray has done it. I didn't quite understand this in earlier years but let's do it right this time :)

Types of changes

  • Bug fix
  • New feature
  • New algorithm
  • Documentation

@vercel
Copy link

vercel bot commented Apr 6, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vwxyzjn/cleanrl/EigjvGurt7a23euzVcw4rCpkeTE1
✅ Preview: https://cleanrl-git-license-vwxyzjn.vercel.app

@gitpod-io
Copy link

gitpod-io bot commented Apr 6, 2022

@vwxyzjn vwxyzjn requested review from dosssman and yooceii April 6, 2022 01:16
@vwxyzjn
Copy link
Owner Author

vwxyzjn commented Apr 6, 2022

@dosssman @yooceii Let me know if you want to add additional attributions.

@yooceii
Copy link
Collaborator

yooceii commented Apr 7, 2022

If everything that is adopted from other open-source projects is included, then it lgtm

@dosssman
Copy link
Collaborator

dosssman commented Apr 7, 2022

PR #153 addsd the relevant license info regarding the SAC algorithm.
Besides that, looks good on my side.

Most of the licenses used seems to be the MIT one anyway ...

@vwxyzjn
Copy link
Owner Author

vwxyzjn commented Apr 7, 2022

LGTM. Merging now.

@vwxyzjn vwxyzjn merged commit 4cfed2b into master Apr 7, 2022
@vwxyzjn vwxyzjn deleted the license branch April 7, 2022 13:00
@vwxyzjn vwxyzjn mentioned this pull request Apr 24, 2022
1 task
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants