Skip to content

T7353: netplug.service is started by vyos-router #944

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

T7353: netplug.service is started by vyos-router #944

merged 1 commit into from
Apr 15, 2025
+2 −0

Conversation

c-po
Copy link
Member

@c-po c-po commented Apr 13, 2025

Change summary

Systemd service is started by vyos-router service

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po
T7353: netplug.service is started by vyos-router
4ce28b3 
Netplug daemon is started last after all interfaces got initialized to
properly monitor them for up/down events.
@github-actions GitHub Actions
Copy link

👍
No issues in PR Title / Commit Title

@github-actions github-actions bot added the current VyOS rolling release label Apr 13, 2025
@c-po c-po mentioned this pull request Apr 13, 2025
Merged
12 tasks
sarthurdev
sarthurdev approved these changes Apr 13, 2025
View reviewed changes
Copy link
Member

@sarthurdev sarthurdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple change that prevents service start until VyOS is ready

dmbaturin
dmbaturin approved these changes Apr 15, 2025
View reviewed changes
Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward update required for the main PR.

@dmbaturin dmbaturin merged commit 7487f63 into vyos:current Apr 15, 2025
7 checks passed
@vyosbot vyosbot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Apr 15, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dmbaturin dmbaturin dmbaturin approved these changes

@sarthurdev sarthurdev sarthurdev approved these changes

Assignees

@c-po c-po

Labels
current VyOS rolling release mirror-completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@c-po @dmbaturin @sarthurdev @vyosbot