chore: More modern types #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boa/test/strategies.py
Outdated
| @@ -43,7 +43,9 @@ def __repr__(self): | |||
|
|
|||
|
|
|||
| def _exclude_filter(fn: Callable) -> Callable: | |||
| def wrapper(*args: Tuple, exclude: Any = None, **kwargs: int) -> SearchStrategy: | |||
| def wrapper( | |||
| *args: tuple[Any, ...], exclude: Any = None, **kwargs: int | |||
There was a problem hiding this comment.
i think this can just be *args: tuple, ...
boa/test/strategies.py
Outdated
| @@ -62,7 +64,7 @@ def wrapper(*args: Tuple, exclude: Any = None, **kwargs: int) -> SearchStrategy: | |||
|
|
|||
| def _check_numeric_bounds( | |||
| type_str: str, min_value: NumberType, max_value: NumberType | |||
| ) -> Tuple: | |||
| ) -> tuple[int | float, int | float]: | |||
There was a problem hiding this comment.
i don't think this type signature is even right. it should return some kind of hypothesis strategy.
There was a problem hiding this comment.
oops, missed some hidden lines. this seems fine, although i think we can get more specific. either tuple[NumberType, NumberType] or tuple[int, int]
charles-cooper
approved these changes
Feb 14, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of
ListandTuple. Uselistandtupleinstead.