-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: Improve Jupyter performance #163
Conversation
- Minified JS with command `npx uglify-js --mangle -o jupyter.min.js -- jupyter.js` - Instead of injecting the whole ethersJS library, just inline the wallet calls
i'm not convinced we want the complexity of introducing minification into the build process. fwiw after compression the minified version saves 900 bytes:
|
code review note: discussed refactoring the jupyter.js file into a full-on extension, but it seems to introduce more complexity than it is worth. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm after removing the dead variables
just tested this -- works amazing! and it's deployed to try.vyperlang.org now :) |
What I did
Improved the jupyter plugin performance considerably
Fixed the empty elements while calling javascript
How I did it
npx uglify-js --mangle -o jupyter.min.js -- jupyter.js
How to verify it
Description for the changelog
Cute Animal Picture