Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: Extract prepare_calldata method #167

Merged
merged 2 commits into from
Feb 19, 2024
Merged

feat: Extract prepare_calldata method #167

merged 2 commits into from
Feb 19, 2024

Conversation

DanielSchiavini
Copy link
Collaborator

@DanielSchiavini DanielSchiavini commented Feb 19, 2024 •
edited
Loading

What I did

  • Added prepare_calldata methods to ABIFunction and ABIOverload

How I did it

  • Extracting the existing code into those functions

How to verify it

  • Everything should still work

Description for the changelog

  • Add support for prepare_metadata methods in ABI functions

Cute Animal Picture

image

@DanielSchiavini DanielSchiavini changed the title Extract prepare_calldata method feat: Extract prepare_calldata method Feb 19, 2024
@DanielSchiavini DanielSchiavini marked this pull request as ready for review February 19, 2024 13:01
@charles-cooper charles-cooper merged commit cd9ca25 into vyperlang:master Feb 19, 2024
5 of 8 checks passed
@DanielSchiavini DanielSchiavini deleted the prepare-calldata branch February 19, 2024 13:04
@DanielSchiavini DanielSchiavini self-assigned this Mar 22, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@charles-cooper charles-cooper charles-cooper approved these changes

Assignees

@DanielSchiavini DanielSchiavini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielSchiavini @charles-cooper