chore: test coverage #183
Merged
chore: test coverage #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boa/ipython.py
Outdated
| @@ -23,6 +23,7 @@ def deployer(self, line, cell): | |||
| if line: | |||
| self.shell.user_ns[line] = c # ret available in user ipython locals | |||
| _contracts[line] = c # ret available in boa.ipython._contracts | |||
| global _ | |||
There was a problem hiding this comment.
yes, otherwise the tests fail:
titanoboa/tests/unitary/test_ipython.py
Line 23 in 0a8640f
There was a problem hiding this comment.
i'm not really sure we need the boa.ipython._ thing btw, since ipython already has the global _ thing working. i don't really see anybody use it, so maybe we could remove it?
charles-cooper
approved these changes
Jun 12, 2024
|
Thank you 3 months later 🥳 🤣 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Cute Animal Picture