-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: output_format
#21
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion - Also deletes the temporary file after compilation
fubuloubu
approved these changes
Sep 5, 2024
Add test for `output_format` and `detect_vyper_version_from_source` Fix tests for vyper 0.4
fubuloubu
reviewed
Sep 5, 2024
DanielSchiavini
changed the title
feat:
feat: Sep 6, 2024
output_format
and detect_vyper_version_from_source
output_format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems fine, but what do you think about having a raw_compile
function which lets you pass specific arguments and directly gives back the stdout?
charles-cooper
approved these changes
Sep 10, 2024
@charles-cooper raw_compile is here: a5c9dae |
DanielSchiavini
added a commit
to vyperlang/titanoboa
that referenced
this pull request
Sep 11, 2024
depends on vyperlang/vvm#21
charles-cooper
approved these changes
Sep 12, 2024
4 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add detect_vyper_version_from_sourceRelated issue: vyperlang/titanoboa#294
How I did it
How to verify it
Checklist