Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: output_format #21

Merged
merged 9 commits into from
Sep 12, 2024
Merged

Conversation

DanielSchiavini
Copy link
Contributor

@DanielSchiavini DanielSchiavini commented Sep 5, 2024

What I did

  • Add output_format kwarg
  • Add detect_vyper_version_from_source
  • Update tests
  • Deletes the temporary file after compilation

Related issue: vyperlang/titanoboa#294

How I did it

How to verify it

Checklist

  • I have confirmed that my PR passes all linting checks
  • I have included test cases
  • I have updated the documentation (README.md)
  • I have added an entry to the changelog

…tion

- Also deletes the temporary file after compilation
Add test for `output_format` and `detect_vyper_version_from_source`
Fix tests for vyper 0.4
vvm/main.py Outdated Show resolved Hide resolved
@DanielSchiavini DanielSchiavini changed the title feat: output_format and detect_vyper_version_from_source feat: output_format Sep 6, 2024
@DanielSchiavini DanielSchiavini marked this pull request as ready for review September 6, 2024 12:52
tests/conftest.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems fine, but what do you think about having a raw_compile function which lets you pass specific arguments and directly gives back the stdout?

@DanielSchiavini
Copy link
Contributor Author

DanielSchiavini commented Sep 11, 2024

@charles-cooper raw_compile is here: a5c9dae
That might be more flexible. Let me know which version you prefer.

DanielSchiavini added a commit to vyperlang/titanoboa that referenced this pull request Sep 11, 2024
@charles-cooper charles-cooper merged commit bc1581f into vyperlang:master Sep 12, 2024
9 of 10 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants