-
-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix[tool]: fix combined_json
output for CLI
#3901
fix[tool]: fix combined_json
output for CLI
#3901
Conversation
the output json would not be produced because Path does not have a json serializer
b1fc635
to
f9b6504
Compare
combined_json
output for CLI
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3901 +/- ##
===========================================
- Coverage 86.33% 59.26% -27.08%
===========================================
Files 92 92
Lines 14036 14036
Branches 3085 3085
===========================================
- Hits 12118 8318 -3800
- Misses 1490 5090 +3600
- Partials 428 628 +200 ☔ View full report in Codecov by Sentry. |
the output json would not be produced because Path does not have a json serializer there are actually tests for `combined_json`, but they test the `compile_files` API directly, whereas the offending code is in the very outer `_cli_helper()` function. the best (long-term) way to test this might be to have a harness which runs the vyper CLI directly from shell, but that is not explored here to reduce scope.
What I did
fix #3900
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture